Summary: | /msg sheriffbot should work | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||
Component: | Tools / Tests | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Normal | CC: | abarth, eric, joepeck, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
WebKit Review Bot
2011-06-16 14:59:00 PDT
/msg sheriffbot help should "just work" http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/irc/ircbot.py#L74 We probably need to override on_privmsg as well as on_pubmsg (or something like that). +1 Created attachment 98276 [details]
Patch
Comment on attachment 98276 [details]
Patch
I like that you can only talk to him in public. rollouts, for example, should be a public experience, no?
I agree that he shouldn't just ignore private messages. I'm just not sure if we should allow commands in private? But maybe I'm naive. 'help' should work in private. 'create-bug' is OK. Not sure about others. Comment on attachment 98276 [details]
Patch
I think Eric meant to R- this patch.
Having some functions but not others work in private is too complicated. Having things in public seems fine. That helps me understand how folks use the tool. |