Bug 62824

Summary: DFG JIT - add support for branch-fusion of compareEq, JSValue comparisons in SpeculativeJIT
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
The patch sam: review+

Gavin Barraclough
Reported 2011-06-16 14:46:25 PDT
CompareEq of non-integer values is the most common cause of speculation failure.
Attachments
The patch (7.96 KB, patch)
2011-06-16 14:48 PDT, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-06-16 14:48:44 PDT
Created attachment 97507 [details] The patch
Sam Weinig
Comment 2 2011-06-16 15:18:12 PDT
Comment on attachment 97507 [details] The patch View in context: https://bugs.webkit.org/attachment.cgi?id=97507&action=review > Source/JavaScriptCore/ChangeLog:16 > + * dfg/DFGSpeculativeJIT.cpp: > + (JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch): > + (JSC::DFG::SpeculativeJIT::compilePeepHoleEq): > + (JSC::DFG::SpeculativeJIT::compile): > + * dfg/DFGSpeculativeJIT.h: > + (JSC::DFG::SpeculativeJIT::detectPeepHoleBranch): > + (JSC::DFG::SpeculativeJIT::isInteger): PLease add data :(
Gavin Barraclough
Comment 3 2011-06-16 16:40:26 PDT
Fixed in r89084
Note You need to log in before you can comment on or make changes to this bug.