Bug 62820

Summary: Introduced SlotVisitor into the project
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: oliver, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Geoffrey Garen
Reported 2011-06-16 14:14:34 PDT
Introduced SlotVisitor into the project
Attachments
Patch (20.43 KB, patch)
2011-06-16 14:20 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (22.26 KB, patch)
2011-06-16 14:25 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (24.37 KB, patch)
2011-06-16 14:33 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-06-16 14:20:15 PDT
Created attachment 97496 [details] Patch
Geoffrey Garen
Comment 2 2011-06-16 14:25:02 PDT
Created attachment 97498 [details] Patch
WebKit Review Bot
Comment 3 2011-06-16 14:26:38 PDT
Attachment 97498 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1 Source/WebCore/dom/NodeFilterCondition.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 4 2011-06-16 14:29:47 PDT
Comment on attachment 97498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97498&action=review r=me if you fix the style problem >> Source/WebCore/dom/NodeFilterCondition.h:32 >> - class MarkStack; >> - typedef MarkStack SlotVisitor; >> + class SlotVisitor; > > Code inside a namespace should not be indented. [whitespace/indent] [4] Fixerate this.
Geoffrey Garen
Comment 5 2011-06-16 14:33:53 PDT
Created attachment 97501 [details] Patch
WebKit Review Bot
Comment 6 2011-06-16 14:35:45 PDT
Attachment 97501 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1 Source/WebCore/dom/NodeFilterCondition.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 7 2011-06-16 15:01:47 PDT
Committed r89069: <http://trac.webkit.org/changeset/89069>
Note You need to log in before you can comment on or make changes to this bug.