| Summary: | Introduced SlotVisitor into the project | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||||||
| Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | oliver, sam, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Geoffrey Garen
2011-06-16 14:14:34 PDT
Created attachment 97496 [details]
Patch
Created attachment 97498 [details]
Patch
Attachment 97498 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1
Source/WebCore/dom/NodeFilterCondition.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 97498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97498&action=review r=me if you fix the style problem >> Source/WebCore/dom/NodeFilterCondition.h:32 >> - class MarkStack; >> - typedef MarkStack SlotVisitor; >> + class SlotVisitor; > > Code inside a namespace should not be indented. [whitespace/indent] [4] Fixerate this. Created attachment 97501 [details]
Patch
Attachment 97501 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1
Source/WebCore/dom/NodeFilterCondition.h:32: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 26 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r89069: <http://trac.webkit.org/changeset/89069> |