Bug 62820 - Introduced SlotVisitor into the project
Summary: Introduced SlotVisitor into the project
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-16 14:14 PDT by Geoffrey Garen
Modified: 2011-06-16 20:37 PDT (History)
3 users (show)

See Also:


Attachments
Patch (20.43 KB, patch)
2011-06-16 14:20 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (22.26 KB, patch)
2011-06-16 14:25 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff
Patch (24.37 KB, patch)
2011-06-16 14:33 PDT, Geoffrey Garen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-06-16 14:14:34 PDT
Introduced SlotVisitor into the project
Comment 1 Geoffrey Garen 2011-06-16 14:20:15 PDT
Created attachment 97496 [details]
Patch
Comment 2 Geoffrey Garen 2011-06-16 14:25:02 PDT
Created attachment 97498 [details]
Patch
Comment 3 WebKit Review Bot 2011-06-16 14:26:38 PDT
Attachment 97498 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1

Source/WebCore/dom/NodeFilterCondition.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Oliver Hunt 2011-06-16 14:29:47 PDT
Comment on attachment 97498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97498&action=review

r=me if you fix the style problem

>> Source/WebCore/dom/NodeFilterCondition.h:32
>> -    class MarkStack;
>> -    typedef MarkStack SlotVisitor;
>> +    class SlotVisitor;
> 
> Code inside a namespace should not be indented.  [whitespace/indent] [4]

Fixerate this.
Comment 5 Geoffrey Garen 2011-06-16 14:33:53 PDT
Created attachment 97501 [details]
Patch
Comment 6 WebKit Review Bot 2011-06-16 14:35:45 PDT
Attachment 97501 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1

Source/WebCore/dom/NodeFilterCondition.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Geoffrey Garen 2011-06-16 15:01:47 PDT
Committed r89069: <http://trac.webkit.org/changeset/89069>