Summary: | Set referrer sooner on a ResourceRequest from a worker | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nate Chapin <japhet> | ||||
Component: | WebCore Misc. | Assignee: | Nate Chapin <japhet> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ap, levin, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Nate Chapin
2011-06-16 11:31:39 PDT
Created attachment 97471 [details]
patch
Comment on attachment 97471 [details]
patch
I can't follow how Referer setting logic works with this patch. For example, will we be getting https workers' URLs sent to the server in this field now? Or was it a problem even before this patch?
(In reply to comment #2) > (From update of attachment 97471 [details]) > I can't follow how Referer setting logic works with this patch. For example, will we be getting https workers' URLs sent to the server in this field now? Or was it a problem even before this patch? The diff cut off at a lousy place. The next line in SubresourceLoader.cpp should enforce referrer blocking regardless of whether we're using the document's outgoingReferrer of the worker's override: http://trac.webkit.org/browser/trunk/Source/WebCore/loader/SubresourceLoader.cpp#L94 Looks good to me. David, do you remember if there was a reason why we didn't implement it this way originally? (In reply to comment #4) > Looks good to me. David, do you remember if there was a reason why we didn't implement it this way originally? In short, it was a bad oversight on my part. As best I can remember, my mental rough outline was to add it into ResourceRequest but was discouraged from adding more there. Unfortunately (for no good reason), I must not have checked to see that it was already there. This is much better. Comment on attachment 97471 [details] patch Clearing flags on attachment: 97471 Committed r89086: <http://trac.webkit.org/changeset/89086> All reviewed patches have been landed. Closing bug. |