Bug 62795

Summary: WebSocket: Clean up pywebsocket handlers
Product: WebKit Reporter: Yuta Kitamura <yutak>
Component: Tools / TestsAssignee: Yuta Kitamura <yutak>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, tkent, ukai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 63689, 63704, 63794    
Bug Blocks: 62786    
Attachments:
Description Flags
Patch none

Description Yuta Kitamura 2011-06-16 06:52:21 PDT
Part one of bug 62786.
Comment 1 Yuta Kitamura 2011-06-16 07:29:11 PDT
Created attachment 97442 [details]
Patch
Comment 2 Kent Tamura 2011-06-16 23:22:30 PDT
Comment on attachment 97442 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97442&action=review

> LayoutTests/ChangeLog:9
> +        Common mistakes are: (1) not raising an exception in the end of a hander,

hander -> handler?

> LayoutTests/ChangeLog:11
> +        This change fixes errors seen among pywebsocket handlers for layout tests.
> +        Common mistakes are: (1) not raising an exception in the end of a hander,
> +        (2) using obsolete handshake format (Hixie's protocol draft 75), (3) style
> +        errors such as bad indentation.

In general, if we fix three erros, we had better to have three patches.
This patch would be acceptable for some reviewers because it's not large.

(1) and (2) seem behavior changes.  Don't they affect existing layout tests?
Comment 3 Yuta Kitamura 2011-06-29 23:18:42 PDT
Comment on attachment 97442 [details]
Patch

Sure, I'm going to split this patch into smaller patches.

I will try to clarify your questions in ChangeLogs of these patches.
Comment 4 Yuta Kitamura 2011-07-04 01:36:18 PDT
This is done. (in three sub-patches: bug 63689, bug 63704, and bug 63794)