Add a function hasRenderer()

• Component: Layout and Rendering
• Status: RESOLVED INVALID

[Roland Steiner]

Currently, the function renderer() is used to both retrieve a node's renderer, as well as to simply check for the presence of a renderer (implicitly converting to bool).

For future implementation changes, notably around SVG shadow tree implementations, separating the latter use-case out into a new function hasRenderer() would be helpful.

[Roland Steiner]

Created attachment 97435 [details]
Patch

[WebKit Review Bot]

Attachment 97435 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/editing/ReplaceSelectionCommand.cpp:151:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 1 in 111 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dimitri Glazkov (Google)]

Rob, Niko, Dirk -- this is a nice exploration of how much work we have ahead of us on making RenderObject multiplex on Node.

[Dimitri Glazkov (Google)]

Comment on attachment 97435 [details]
Patch

Removing r?, since this is just an exploration at the moment.

[Alexey Proskuryakov]

> For future implementation changes, notably around SVG shadow tree implementations, separating the latter use-case out into a new function hasRenderer() would be helpful.

Does this mean that non-null renderer() result will not be equivalent to hasRenderer() returning true?

[Hajime Morrita]

Closing - we have no concrete plan which relies on this.