Bug 6276

Summary:

Image thumbnails are misplaced on forum.2ostrov.ru

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

VERIFIED FIXED

Severity:

Major

CC:

mitz

Priority:

Keywords:

HasReduction

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://forum.2ostrov.ru/viewtopic.php?t=343

Attachments:

Description	Flags
screenshot	none
Testcase	none
Testcase	none
Don't set the object's wrapper box to 0 if it's already been adopted by another box	mjs: review+
new screenshot	none
Reduction of the repaint issue (extra horizontal lines)	none

Alexey Proskuryakov

Reported 2005-12-28 13:56:35 PST

When opening the bug URL for the first time (or, with lower probability, reloading it), some images on this page get completely misplaced.

Attachments
screenshot (505.96 KB, image/png) 2005-12-28 14:02 PST, Alexey Proskuryakov	no flags	Details
Testcase (967 bytes, text/html) 2006-01-06 15:11 PST, mitz	no flags	Details
Testcase (1.20 KB, text/html) 2006-01-07 02:26 PST, mitz	no flags	Details
Don't set the object's wrapper box to 0 if it's already been adopted by another box (7.87 KB, patch) 2006-01-07 13:22 PST, mitz	mjs: review+	Details Formatted Diff Diff
new screenshot (31.19 KB, image/png) 2006-01-07 13:35 PST, Alexey Proskuryakov	no flags	Details
Reduction of the repaint issue (extra horizontal lines) (280 bytes, text/html) 2006-01-24 08:55 PST, mitz	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2005-12-28 14:02:13 PST

Created attachment 5343 [details] screenshot

Eric Seidel (no email)

Comment 2 2005-12-28 14:07:48 PST

This might be related to: http://bugzilla.opendarwin.org/show_bug.cgi?id=3509

mitz

Comment 3 2005-12-30 15:13:40 PST

I think there are two different categories of bugs here, each represented in at least one bugzilla bug. One is the incomplete repaint, bug 3509 and bug 6728, where if you force repaint (e.g. by doing Select All and deselecting) the anomaly is gone, and one is the broken layout (like in this bug, or sometimes happens in the Reviews column at http://www.loopware.com/iflash/ ), where forced repaint doesn't help, and you can see the problem in the render tree (if you know what to look for).

mitz

Comment 4 2006-01-06 15:11:42 PST

Created attachment 5517 [details] Testcase

Alexey Proskuryakov

Comment 5 2006-01-06 15:21:54 PST

An impressive reduction! Not sure if it's the same bug, though - the reduction only fails on ToT, not on stock 2.0.2, like the original page.

mitz

Comment 6 2006-01-07 02:26:11 PST

Created attachment 5524 [details] Testcase The previous testcase depended on a regression from the fix for bug 5172.

mitz

Comment 7 2006-01-07 13:22:06 PST

Created attachment 5531 [details] Don't set the object's wrapper box to 0 if it's already been adopted by another box

Alexey Proskuryakov

Comment 8 2006-01-07 13:35:11 PST

Created attachment 5532 [details] new screenshot This fix makes the behavior much better, but not yet perfect, unfortunately. As the images load, and the message cell grows, the cell to the left doesn't redraw properly...

mitz

Comment 9 2006-01-07 14:29:01 PST

(In reply to comment #8) > Created an attachment (id=5532) [edit] > new screenshot That looks like a separate (repaint, not relayout) issue, perhaps bug 3509.

Maciej Stachowiak

Comment 10 2006-01-07 22:02:19 PST

Comment on attachment 5531 [details] Don't set the object's wrapper box to 0 if it's already been adopted by another box r=me

David Kilzer (:ddkilzer)

Comment 11 2006-01-08 09:35:24 PST

I have confirmed that the problem shown in Attachment 5532 [details] (the extra horizontal lines on the left side of the page) behaves like Bug 3509, and thus is probably a separate issue.

Alexey Proskuryakov

Comment 12 2006-01-09 00:42:04 PST

Will track bug 3509 to verify that fixing it fixes the site completely.

Alexey Proskuryakov

Comment 13 2006-01-21 03:11:36 PST

Mitz says that the fix to bug 3509 is not going to fix this remaining issue - will file a followup when it's final.

mitz

Comment 14 2006-01-24 08:55:18 PST

Created attachment 5911 [details] Reduction of the repaint issue (extra horizontal lines) Click the Grow button, then force a repaint (e.g. by switching to another tab).

Alexey Proskuryakov

Comment 15 2006-01-26 05:37:47 PST

The remaining repaint issue is now tracked as bug 6769.

Note You need to log in before you can comment on or make changes to this bug.