Bug 62751

Summary:

we should only log the test names to the tests_run.txt files during layout_tests

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

Tools / Tests

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Trivial

CC:

abarth, eric, ojan, ossy, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
Patch	none
add testing of the contents of tests_run*.txt per review feedback from eseidel	none

Description Dirk Pranke 2011-06-15 13:27:36 PDT

Currently, both ORWT and NRWT log the full path to the test being run to a file in the layout-test-results directory. There's not really any need for the full path, so we should just log the test names (which are relative paths using unix-style directory separators) instead. See bug 58692 for a bit of background on the change that added the logging to ORWT (NRWT has had this forever).

Comment 1 Dirk Pranke 2011-06-15 13:31:52 PDT

Created attachment 97355 [details]
Patch

Comment 2 Eric Seidel (no email) 2011-06-15 15:08:04 PDT

Comment on attachment 97355 [details]
Patch

Seems fine.  But would be nice to have a unit test.

Comment 3 Eric Seidel (no email) 2011-06-15 15:08:27 PDT

(I only care about worker.py, ORWT is deadman walking.)

Comment 4 Csaba Osztrogonác 2011-06-15 23:33:00 PDT

(In reply to comment #3)
> (I only care about worker.py, ORWT is deadman walking.)

rs=me for ORWT change. Thanks for the fix.

Comment 5 Dirk Pranke 2011-06-20 12:39:04 PDT

Created attachment 97840 [details]
add testing of the contents of tests_run*.txt per review feedback from eseidel

Comment 6 WebKit Review Bot 2011-06-20 14:30:41 PDT

Comment on attachment 97840 [details]
add testing of the contents of tests_run*.txt per review feedback from eseidel

Clearing flags on attachment: 97840

Committed r89290: <http://trac.webkit.org/changeset/89290>

Comment 7 WebKit Review Bot 2011-06-20 14:30:46 PDT

All reviewed patches have been landed.  Closing bug.