Bug 62748

Summary: Move FileChooser::basenameForWidth to RenderTheme::fileListNameForWidth, eliminate gnarly FileChooserFoo proliferation.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62069    
Attachments:
Description Flags
Patch
none
Let's cook this on bots. tkent: review+

Dimitri Glazkov (Google)
Reported 2011-06-15 12:50:20 PDT
Move FileChooser::basenameForWidth to RenderTheme::fileListNameForWidth, eliminate gnarly FileChooserFoo proliferation.
Attachments
Patch (50.10 KB, patch)
2011-06-15 12:54 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Let's cook this on bots. (49.74 KB, patch)
2011-06-15 13:15 PDT, Dimitri Glazkov (Google) 		tkent: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-06-15 12:54:55 PDT
Created attachment 97349 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-06-15 12:55:56 PDT
Need to cook on bots.
Dimitri Glazkov (Google)
Comment 3 2011-06-15 13:01:19 PDT
Comment on attachment 97349 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97349&action=review > Source/WebCore/platform/qt/RenderThemeQt.cpp:189 > + QApplication defaultButtonFont = QApplication::font(&button); GAH! Didn't mean that.
Dimitri Glazkov (Google)
Comment 4 2011-06-15 13:15:42 PDT
Created attachment 97352 [details] Let's cook this on bots.
Dimitri Glazkov (Google)
Comment 5 2011-06-15 13:41:29 PDT
Comment on attachment 97352 [details] Let's cook this on bots. I am optimistic.
Kent Tamura
Comment 6 2011-06-15 18:12:23 PDT
Comment on attachment 97352 [details] Let's cook this on bots. Qt EWS and EFL EWS don't work for now. Please pay attention when you land this.
Dimitri Glazkov (Google)
Comment 7 2011-06-16 10:33:27 PDT
Committed r89039: <http://trac.webkit.org/changeset/89039>
Note You need to log in before you can comment on or make changes to this bug.