Bug 62748

Summary:

Move FileChooser::basenameForWidth to RenderTheme::fileListNameForWidth, eliminate gnarly FileChooserFoo proliferation.

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

New Bugs

Assignee:

Dimitri Glazkov (Google) <dglazkov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

62069

Attachments:

Description	Flags
Patch	none
Let's cook this on bots.	tkent: review+

Description Dimitri Glazkov (Google) 2011-06-15 12:50:20 PDT

Move FileChooser::basenameForWidth to RenderTheme::fileListNameForWidth, eliminate gnarly FileChooserFoo proliferation.

Comment 1 Dimitri Glazkov (Google) 2011-06-15 12:54:55 PDT

Created attachment 97349 [details]
Patch

Comment 2 Dimitri Glazkov (Google) 2011-06-15 12:55:56 PDT

Need to cook on bots.

Comment 3 Dimitri Glazkov (Google) 2011-06-15 13:01:19 PDT

Comment on attachment 97349 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97349&action=review

> Source/WebCore/platform/qt/RenderThemeQt.cpp:189
> +    QApplication defaultButtonFont = QApplication::font(&button);

GAH! Didn't mean that.

Comment 4 Dimitri Glazkov (Google) 2011-06-15 13:15:42 PDT

Created attachment 97352 [details]
Let's cook this on bots.

Comment 5 Dimitri Glazkov (Google) 2011-06-15 13:41:29 PDT

Comment on attachment 97352 [details]
Let's cook this on bots.

I am optimistic.

Comment 6 Kent Tamura 2011-06-15 18:12:23 PDT

Comment on attachment 97352 [details]
Let's cook this on bots.

Qt EWS and EFL EWS don't work for now.  Please pay attention when you land this.

Comment 7 Dimitri Glazkov (Google) 2011-06-16 10:33:27 PDT

Committed r89039: <http://trac.webkit.org/changeset/89039>