| Summary: | [Qt] enable icu build not work | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | qi <qi.2.zhang> | ||||||
| Component: | New Bugs | Assignee: | qi <qi.2.zhang> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | christian.webkit, cshu, kenneth, kimmo.t.kinnunen, laszlo.gombos, webkit.review.bot, zalan | ||||||
| Priority: | P2 | Keywords: | Qt | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
|
Description
qi
2011-06-15 12:11:08 PDT
Created attachment 97342 [details] patch See https://bugs.webkit.org/attachment.cgi?bugid=60786, which define use_system_icu to enable WTF_USE_QT4_UNICODE or WTF_USE_ICU_UNICODE. But in Platform.h we still keep the default flag to enable WTF_USE_QT4_UNICODE, which means when we use use_system_icu, actually both of them will be enabled. Comment on attachment 97342 [details]
patch
I prefer to keep these rules in the source code and not in the build system. Instead of removing this from the source code, can we do the following ?
#ifndef WTF_USE_ICU_UNICODE
#define WTF_USE_QT4_UNICODE 1
#endif
Created attachment 97441 [details]
patch2
Renew the patch.
Comment on attachment 97441 [details]
patch2
Looks good to me. Thanks.
Comment on attachment 97441 [details] patch2 Clearing flags on attachment: 97441 Committed r89037: <http://trac.webkit.org/changeset/89037> All reviewed patches have been landed. Closing bug. |