Bug 62744

Summary: [Qt] enable icu build not work
Product: WebKit Reporter: qi <qi.2.zhang>
Component: New BugsAssignee: qi <qi.2.zhang>
Status: RESOLVED FIXED    
Severity: Normal CC: christian.webkit, cshu, kenneth, kimmo.t.kinnunen, laszlo.gombos, webkit.review.bot, zalan
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch
none
patch2 none

qi
Reported 2011-06-15 12:11:08 PDT
enable icu build not work
Attachments
patch (1.15 KB, patch)
2011-06-15 12:21 PDT, qi 		no flags
DetailsFormatted DiffDiff
patch2 (1.04 KB, patch)
2011-06-16 07:27 PDT, qi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
qi
Comment 1 2011-06-15 12:21:57 PDT
Created attachment 97342 [details] patch See https://bugs.webkit.org/attachment.cgi?bugid=60786, which define use_system_icu to enable WTF_USE_QT4_UNICODE or WTF_USE_ICU_UNICODE. But in Platform.h we still keep the default flag to enable WTF_USE_QT4_UNICODE, which means when we use use_system_icu, actually both of them will be enabled.
Laszlo Gombos
Comment 2 2011-06-16 06:22:53 PDT
Comment on attachment 97342 [details] patch I prefer to keep these rules in the source code and not in the build system. Instead of removing this from the source code, can we do the following ? #ifndef WTF_USE_ICU_UNICODE #define WTF_USE_QT4_UNICODE 1 #endif
qi
Comment 3 2011-06-16 07:27:02 PDT
Created attachment 97441 [details] patch2 Renew the patch.
Laszlo Gombos
Comment 4 2011-06-16 09:13:14 PDT
Comment on attachment 97441 [details] patch2 Looks good to me. Thanks.
WebKit Review Bot
Comment 5 2011-06-16 09:56:09 PDT
Comment on attachment 97441 [details] patch2 Clearing flags on attachment: 97441 Committed r89037: <http://trac.webkit.org/changeset/89037>
WebKit Review Bot
Comment 6 2011-06-16 09:56:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.