Bug 62734

Summary:

Layout tests editing/inserting/return-key-in-hidden-field.html and return-key-span-start.html don't run in webkit2

Product:

WebKit

Reporter:

Annie Sullivan <sullivan>

Component:

HTML Editing

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Annie Sullivan

Reported 2011-06-15 09:49:26 PDT

These tests would run correctly if we used execCommand(insertParagraph) instead of eventSender('\n')

Attachments
Patch (4.35 KB, patch) 2011-06-15 11:50 PDT, Annie Sullivan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Annie Sullivan

Comment 1 2011-06-15 11:50:05 PDT

Created attachment 97337 [details] Patch

Annie Sullivan

Comment 2 2011-06-15 11:52:29 PDT

(In reply to comment #1) > Created an attachment (id=97337) [details] > Patch Note on this patch: switching to execCommand(insertParagraph) resulted in an extra newline being added in return-key-in-hidden-field. I am not sure if this is okay, or if I have changed the behavior of the test too much. Also, the qt platform has its own expected results file (which has one more newline than the original). Not sure how to check if it needs to be updated (I only have a mac to test on locally)

Ryosuke Niwa

Comment 3 2011-06-15 12:10:00 PDT

Comment on attachment 97337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97337&action=review > LayoutTests/editing/inserting/return-key-in-hidden-field-expected.txt:6 > + Interesting to see extra line added here. Maybe because we're in standard mode now?

Ryosuke Niwa

Comment 4 2011-06-15 12:10:08 PDT

cq?

Annie Sullivan

Comment 5 2011-06-15 12:53:33 PDT

I'd like to put this patch in the commit queue, but I won't be able to watch it while I am at the conference. Should we wait till I get back in the office on Friday?

Annie Sullivan

Comment 6 2011-06-15 13:03:09 PDT

(In reply to comment #3) > Interesting to see extra line added here. Maybe because we're in standard mode now? I tried deleting <!DOCTYPE html> and got the same result.

Ryosuke Niwa

Comment 7 2011-06-15 13:05:06 PDT

(In reply to comment #5) > I'd like to put this patch in the commit queue, but I won't be able to watch it while I am at the conference. Should we wait till I get back in the office on Friday? That sounds good to me.

WebKit Review Bot

Comment 8 2011-06-17 11:20:45 PDT

Comment on attachment 97337 [details] Patch Clearing flags on attachment: 97337 Committed r89149: <http://trac.webkit.org/changeset/89149>

WebKit Review Bot

Comment 9 2011-06-17 11:20:49 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.