Bug 62713

Summary:

[EFL] Implement animationXXX functions for Progress Tag

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, rakuco, tkent, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed Patch	lucas.de.marchi: review-, lucas.de.marchi: commit-queue-
Patch	none

Gyuyoung Kim

Reported 2011-06-15 03:24:30 PDT

Progress tag need to implement acnimationXXX functions in order to show animation or progress tag. animationRepeatIntervalForProgressBar() animationDurationForProgressBar() Because, RenderProgress decides to show update progress bar's animation according to the functions. I add the functions to EFL port referencing to GTK port.

Attachments
Proposed Patch (2.62 KB, patch) 2011-06-15 03:28 PDT, Gyuyoung Kim	lucas.de.marchi: review- lucas.de.marchi: commit-queue-	Details Formatted Diff Diff
Patch (3.03 KB, patch) 2011-06-15 08:50 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2011-06-15 03:28:21 PDT

Created attachment 97267 [details] Proposed Patch

Raphael Kubo da Costa (:rakuco)

Comment 2 2011-06-15 06:13:13 PDT

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:1095 > +// These values have been copied from RenderThemeGtk.cpp I'd rather have all these static consts in the beginning of the file, before the actual method implementations. > Source/WebCore/platform/efl/RenderThemeEfl.cpp:1096 > +static const int progressActivityBlocks = 5; This one doesn't seem to be used.

Gyuyoung Kim

Comment 3 2011-06-15 08:50:15 PDT

Created attachment 97300 [details] Patch Ok, patch is modified.

Leandro Pereira

Comment 4 2011-06-15 09:38:56 PDT

Comment on attachment 97300 [details] Patch LGTM.

Kent Tamura

Comment 5 2011-06-15 16:57:28 PDT

Comment on attachment 97300 [details] Patch Rubber stamped by me.

WebKit Review Bot

Comment 6 2011-06-15 17:37:14 PDT

Comment on attachment 97300 [details] Patch Clearing flags on attachment: 97300 Committed r88985: <http://trac.webkit.org/changeset/88985>

WebKit Review Bot

Comment 7 2011-06-15 17:37:19 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.