Bug 62701

Summary: Web Inspector: script select can be too wide.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 62728    
Bug Blocks:    
Attachments:
Description Flags
Patch.
none
Patch.
none
Patch. yurys: review+

Pavel Podivilov
Reported 2011-06-15 00:45:27 PDT
Web Inspector: script select can be too wide. We should truncate script name in options text (tooltip still displays the whole url).
Attachments
Patch. (10.30 KB, patch)
2011-06-15 00:46 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch. (9.47 KB, patch)
2011-06-15 00:47 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch. (9.42 KB, patch)
2011-06-15 01:53 PDT, Pavel Podivilov 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-06-15 00:46:06 PDT
Created attachment 97245 [details] Patch.
Pavel Podivilov
Comment 2 2011-06-15 00:47:35 PDT
Created attachment 97246 [details] Patch.
Yury Semikhatsky
Comment 3 2011-06-15 01:41:35 PDT
Comment on attachment 97246 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=97246&action=review > LayoutTests/inspector/debugger/scripts-panel-expected.txt:19 > +text: very_looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooon..., tooltip: very_looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong_url Is result the same on all platforms?
Yury Semikhatsky
Comment 4 2011-06-15 01:48:15 PDT
Comment on attachment 97246 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=97246&action=review > Source/WebCore/inspector/front-end/ScriptsPanel.js:304 > + WebInspector.log(displayName.length); Remove this line. > Source/WebCore/inspector/front-end/ScriptsPanel.js:306 > + displayName = displayName.substring(0, 100) + "..."; Ignore my previous comment about test expectations I thought you were truncating the display name based on the screen width which we probably should do instead of specifying 100 limit for all resolutions.
Pavel Podivilov
Comment 5 2011-06-15 01:53:44 PDT
Created attachment 97259 [details] Patch.
Pavel Podivilov
Comment 6 2011-06-15 02:02:53 PDT
(In reply to comment #4) > (From update of attachment 97246 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97246&action=review > > > Source/WebCore/inspector/front-end/ScriptsPanel.js:304 > > + WebInspector.log(displayName.length); > > Remove this line. Done.
Pavel Podivilov
Comment 7 2011-06-15 03:39:15 PDT
Committed r88916: <http://trac.webkit.org/changeset/88916>
Pavel Podivilov
Comment 8 2011-06-15 08:19:02 PDT
Committed r88936: <http://trac.webkit.org/changeset/88936>
Note You need to log in before you can comment on or make changes to this bug.