Bug 62692

Summary: [CMAKE][WK2] include cmakeconfig.h in WebKit2/config.h
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, leandro, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Ryuan Choi 2011-06-14 20:08:20 PDT 
Patch will be updated.
Comment 1 Ryuan Choi 2011-06-14 23:50:05 PDT 
Created attachment 97241 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-06-15 05:57:59 PDT 
Looks OK to me, informal r+.
Comment 3 Lucas De Marchi 2011-06-15 07:08:03 PDT 
Comment on attachment 97241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97241&action=review

> Source/WebKit2/config.h:61
> -#if defined(BUILDING_QT__) || defined(BUILDING_GTK__)
> +#if defined(BUILDING_QT__) || defined(BUILDING_GTK__) || defined(BUILDING_WITH_CMAKE)
>  
>  #define WTF_USE_JSC 1
>  #define WTF_USE_V8 0

This one looks wrong to me. Isn't there any port that might want WTF_USE_V8? Wasn't the EFL port recently adding support to use V8 instead of JSC?
Comment 4 Ryuan Choi 2011-06-15 16:36:15 PDT 
(In reply to comment #3)
> (From update of attachment 97241 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97241&action=review
> 
> > Source/WebKit2/config.h:61
> > -#if defined(BUILDING_QT__) || defined(BUILDING_GTK__)
> > +#if defined(BUILDING_QT__) || defined(BUILDING_GTK__) || defined(BUILDING_WITH_CMAKE)
> >  
> >  #define WTF_USE_JSC 1
> >  #define WTF_USE_V8 0
> 
> This one looks wrong to me. Isn't there any port that might want WTF_USE_V8? Wasn't the EFL port recently adding support to use V8 instead of JSC?

Right, it's not good, but I don't know that webkit2 supports v8 now.
But, I'll check once more to find better way.

BTW, WebKit/EFL doesn't support to use v8 yet. I am waiting Bug 61350 and need to clean up other local patches because it's too old. :(

Thanks.
Comment 5 Ryuan Choi 2011-06-15 22:27:56 PDT 
Created attachment 97400 [details]
Patch
Comment 6 Ryuan Choi 2011-06-15 22:37:00 PDT 
Created attachment 97402 [details]
Patch
Comment 7 Eric Seidel (no email) 2011-09-12 15:36:32 PDT 
Comment on attachment 97402 [details]
Patch

rs=me.
Comment 8 WebKit Review Bot 2011-09-12 20:29:50 PDT 
Comment on attachment 97402 [details]
Patch

Clearing flags on attachment: 97402

Committed r95005: <http://trac.webkit.org/changeset/95005>
Comment 9 WebKit Review Bot 2011-09-12 20:29:56 PDT 
All reviewed patches have been landed.  Closing bug.