Bug 62679 – Add notify handler to trigger MemoryPressureHandler in all builds

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Michael Saboff]

Remove the #ifndef NDEBUG around the installation of the SIGUSR2 dispatch for triggering MemoryPressureHandler::respondToMemoryPressure().

[Michael Saboff]

Created attachment 97314 [details]
Proposed patch

[Geoffrey Garen]

Comment on attachment 97314 [details]
Proposed patch

r=me

[Michael Saboff]

Created attachment 97703 [details]
Updated patch using notify

[Darin Adler]

Comment on attachment 97703 [details]
Updated patch using notify

View in context: https://bugs.webkit.org/attachment.cgi?id=97703&action=review

> Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:55
> +static int notifyToken;

This can go inside the function where it’s used instead of at the file level.

> Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm:72
> +    notify_register_dispatch("com.apple.WebKit.lowMemory", &notifyToken,
> +                             dispatch_get_main_queue(), ^(int) { memoryPressureHandler().respondToMemoryPressure();});

This is not WebKit project style indentation. We don't line up things with parentheses on the line before

I suggest "org.WebKit.lowMemory" instead of "com.apple.WebKit.lowMemory".

[Eric Seidel (no email)]

Comment on attachment 97314 [details]
Proposed patch

Cleared Geoffrey Garen's review+ from obsolete attachment 97314 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Michael Saboff]

Committed r89214: <http://trac.webkit.org/changeset/89214>