Bug 62649

Summary: Incorrect #if[n]def for building without DISPATCH_VM_PRESSURE
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: WebCore Misc.Assignee: Michael Saboff <msaboff>
Severity: Normal CC: aestes, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 62652    
Bug Blocks:    
Description Flags
Proposed patch
joepeck: review+
Updated patch
Right updated patch joepeck: review+

Description Michael Saboff 2011-06-14 10:32:59 PDT
The #ifdef DISPATCH_VM_PRESSURE on line 43 of MemoryPressureHandlerMac.mm should actually be #ifndef.
Comment 1 Michael Saboff 2011-06-14 10:49:56 PDT
Created attachment 97140 [details]
Proposed patch
Comment 2 Joseph Pecoraro 2011-06-14 10:51:12 PDT
Comment on attachment 97140 [details]
Proposed patch

Comment 3 Michael Saboff 2011-06-14 10:55:12 PDT
Committed r88823: <http://trac.webkit.org/changeset/88823>
Comment 4 Andy Estes 2011-06-14 11:21:44 PDT
DISPATCH_VM_PRESSURE is an enum, not a macro, so this check doesn't actually work and ends up breaking the build on machines that do have the system header.
Comment 5 Andy Estes 2011-06-14 12:46:50 PDT
http://trac.webkit.org/changeset/88829 rolled this out. Reopening.
Comment 6 Michael Saboff 2011-06-14 15:35:33 PDT
Created attachment 97173 [details]
Updated patch
Comment 7 Michael Saboff 2011-06-14 15:38:14 PDT
Created attachment 97176 [details]
Right updated patch
Comment 8 Joseph Pecoraro 2011-06-14 15:39:28 PDT
Comment on attachment 97176 [details]
Right updated patch

Thanks again.
Comment 9 Michael Saboff 2011-06-14 16:30:42 PDT
Committed r88871: <http://trac.webkit.org/changeset/88871>