Summary: | Web Inspector: "data" URLs not detected in CSS url(...) values properly | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexander Pavlov (apavlov) <apavlov> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Alexander Pavlov (apavlov) <apavlov> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Alexander Pavlov (apavlov)
2011-06-14 09:11:21 PDT
Created attachment 97133 [details]
[PATCH] Suggested fix
Comment on attachment 97133 [details] [PATCH] Suggested fix View in context: https://bugs.webkit.org/attachment.cgi?id=97133&action=review > Source/WebCore/inspector/front-end/AuditRules.js:665 > + if (!parsedURL || !parsedURL.isDataURL) { This check seems wrong. Now all parsed non-data urls fall under this branch. > Source/WebCore/inspector/front-end/CookieItemsView.js:243 > + if (!url || url.isDataURL || !this.cookieDomainMatchesResourceDomain(cookie.domain, url.host)) Will this work as is? > Source/WebCore/inspector/front-end/inspector.js:1320 > + if (parsedHref && (parsedHref.scheme || parsedHref.isDataURL)) No need to change this. Created attachment 97137 [details]
[PATCH] Comments addressed, a simplified approach applied
Committed: <http://trac.webkit.org/changeset/88920> Created attachment 97284 [details]
Patch
Comment on attachment 97284 [details]
Patch
This patch has already landed.
(In reply to comment #6) > (From update of attachment 97284 [details]) > This patch has already landed. Sorry, it was my mistake while learning how to use Tools/Scripts/webkit-patch |