Bug 62635

Summary: KeywordLookupGenerator's Trie does not work with Python 3
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Tools / TestsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Enhancement CC: dpranke, eric, kling, levin, mihaip, ojan, oliver, webkit.review.bot
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2011-06-14 07:44:08 PDT
In Python 3, the dictionary's items() function returns an iterator instead of a list of tuple. dict.items()[0] cannot work. Fix that when you have 5 minutes :)
Attachments
Patch (1.68 KB, patch)
2011-06-14 08:27 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-06-14 08:27:00 PDT
Created attachment 97122 [details] Patch
Eric Seidel (no email)
Comment 2 2011-06-14 08:45:58 PDT
Comment on attachment 97122 [details] Patch Odd that there isn't a nicer way to do this.
Oliver Hunt
Comment 3 2011-06-14 08:47:01 PDT
Comment on attachment 97122 [details] Patch Yay for languages that randomly break existing content.
Benjamin Poulain
Comment 4 2011-06-14 08:48:29 PDT
(In reply to comment #2) > (From update of attachment 97122 [details]) > Odd that there isn't a nicer way to do this. When we drop support for Python 2.5, we can use the global function next().
Eric Seidel (no email)
Comment 5 2011-06-14 08:52:17 PDT
I see, that wasn't clear to me from your comment for some reason.
WebKit Review Bot
Comment 6 2011-06-14 09:25:16 PDT
Comment on attachment 97122 [details] Patch Clearing flags on attachment: 97122 Committed r88807: <http://trac.webkit.org/changeset/88807>
WebKit Review Bot
Comment 7 2011-06-14 09:25:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.