Bug 62632

Summary: [Qt] Don't include convenience "QWebFoo" headers in WebKit code.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Tools / TestsAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch benjamin: review+

Andreas Kling
Reported 2011-06-14 06:35:29 PDT
We shouldn't make assumptions about these headers being available and pointing to the right qwebfoo.h
Attachments
Proposed patch (1.01 KB, patch)
2011-06-14 06:37 PDT, Andreas Kling 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-06-14 06:37:21 PDT
Created attachment 97107 [details] Proposed patch
WebKit Review Bot
Comment 2 2011-06-14 06:38:38 PDT
Attachment 97107 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1 Source/WebKit/qt/WebCoreSupport/FrameNetworkingContextQt.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2011-06-14 06:54:21 PDT
Committed r88795: <http://trac.webkit.org/changeset/88795>
Ademar Reis
Comment 4 2011-06-14 09:25:20 PDT
Revision r88795 cherry-picked into qtwebkit-2.2 with commit ceea7a3 <http://gitorious.org/webkit/qtwebkit/commit/ceea7a3>
Note You need to log in before you can comment on or make changes to this bug.