Summary: | fast/workers/worker-close.html is flaky on slower machines. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Levin <levin> | ||||
Component: | Tools / Tests | Assignee: | David Levin <levin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, dimich, dslomov, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
David Levin
2011-06-13 16:55:05 PDT
Created attachment 97036 [details]
Patch
Comment on attachment 97036 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97036&action=review > LayoutTests/fast/workers/worker-close.html:46 > + timeout = setTimeout(testErrorAfterClose, 1000); Do we need a 1000ms delay now? (In reply to comment #2) > (From update of attachment 97036 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97036&action=review > > > LayoutTests/fast/workers/worker-close.html:46 > > + timeout = setTimeout(testErrorAfterClose, 1000); > > Do we need a 1000ms delay now? The delay wasn't about waiting for this response. It was about waiting to see if it got back a response to the "worker.postMessage("ping");" message. Comment on attachment 97036 [details]
Patch
Thanks!
Comment on attachment 97036 [details] Patch Clearing flags on attachment: 97036 Committed r88746: <http://trac.webkit.org/changeset/88746> All reviewed patches have been landed. Closing bug. |