Bug 62607

Summary: [chromium] Disable drawing for huge mask layers
Product: WebKit Reporter: Adrienne Walker <enne>
Component: New BugsAssignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch jamesr: review+

Adrienne Walker
Reported 2011-06-13 16:40:23 PDT
[chromium] Disable drawing for huge mask layers
Attachments
Patch (4.60 KB, patch)
2011-06-13 16:42 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
Patch (5.65 KB, patch)
2011-06-13 17:01 PDT, Adrienne Walker 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2011-06-13 16:42:20 PDT
Created attachment 97032 [details] Patch
James Robinson
Comment 2 2011-06-13 16:50:43 PDT
Comment on attachment 97032 [details] Patch Will we still try to upload tiles for giant mask layers when returning false to drawsContent()?
Adrienne Walker
Comment 3 2011-06-13 17:01:41 PDT
Created attachment 97039 [details] Patch
Adrienne Walker
Comment 4 2011-06-13 17:02:49 PDT
Excellent point. We weren't uploading tiles, but we were painting unnecessarily and then holding onto that gigantic paint buffer because the tiler never uploaded it.
James Robinson
Comment 5 2011-06-13 17:12:02 PDT
Comment on attachment 97039 [details] Patch Even better!
Adrienne Walker
Comment 6 2011-06-14 10:44:56 PDT
Committed r88822: <http://trac.webkit.org/changeset/88822>
Note You need to log in before you can comment on or make changes to this bug.