Bug 62604

Summary: [CMAKE] Add ENABLE_TOUCH_ICON_LOADING feature.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, ljaehun.lim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Ryuan Choi 2011-06-13 15:15:33 PDT 
Patch will be updated.
Comment 1 Ryuan Choi 2011-06-13 15:22:16 PDT 
Created attachment 97016 [details]
Patch
Comment 2 Lucas De Marchi 2011-06-13 19:36:04 PDT 
Comment on attachment 97016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97016&action=review

Isn't there any additional files that need to be compiled? Otherwise looks good.

> ChangeLog:8
> +        Add feature to enable or disable ENABLE_TOUCH_ICON which support

supports

> Source/cmakeconfig.h.cmake:39
> +#cmakedefine01 ENABLE_TOUCH_ICO_LOADING

ICON
Comment 3 Ryuan Choi 2011-06-13 22:05:38 PDT 
Created attachment 97066 [details]
Patch
Comment 4 Ryuan Choi 2011-06-13 22:10:18 PDT 
(In reply to comment #2)
> (From update of attachment 97016 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97016&action=review
> 
> Isn't there any additional files that need to be compiled? Otherwise looks good.
Compiling is fine without any additional files, but we need to investigate move for using those icon.

> 
> > ChangeLog:8
> > +        Add feature to enable or disable ENABLE_TOUCH_ICON which support
> 
> supports
> 
> > Source/cmakeconfig.h.cmake:39
> > +#cmakedefine01 ENABLE_TOUCH_ICO_LOADING
> 
> ICON

Thanks, done.
Comment 5 Lucas De Marchi 2011-06-14 05:51:09 PDT 
(In reply to comment #4)
> (In reply to comment #2)
> > (From update of attachment 97016 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=97016&action=review
> > 
> > Isn't there any additional files that need to be compiled? Otherwise looks good.
> Compiling is fine without any additional files, but we need to investigate move for using those icon.

If there are any file that is not specific to EFL or another port, It should be added on this patch as well.

You can easily checking this by investigating the build system of other ports that enable this feature (removing the platform/PORT/* and xxxxxPORT.[c|h] files)
Comment 6 Eric Seidel (no email) 2011-06-14 08:48:54 PDT 
Comment on attachment 97066 [details]
Patch

OK.
Comment 7 WebKit Review Bot 2011-06-14 09:29:28 PDT 
Comment on attachment 97066 [details]
Patch

Clearing flags on attachment: 97066

Committed r88809: <http://trac.webkit.org/changeset/88809>
Comment 8 WebKit Review Bot 2011-06-14 09:29:33 PDT 
All reviewed patches have been landed.  Closing bug.