Bug 62534

Summary: [GTK] Add configure option to enable/disable register protocol handler
Product: WebKit Reporter: Joone Hur <joone.hur>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64247    
Attachments:
Description Flags
Proposed Patch
mrobinson: review+
Updated Patch none

Joone Hur
Reported 2011-06-13 01:13:47 PDT
This patch just adds configure option to enable/disable register protocol handler. So, it needs more code to use register protocol handler.
Attachments
Proposed Patch (5.91 KB, patch)
2011-06-13 02:02 PDT, Joone Hur 		mrobinson: review+
DetailsFormatted DiffDiff
Updated Patch (5.94 KB, patch)
2011-06-13 18:49 PDT, Joone Hur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joone Hur
Comment 1 2011-06-13 02:02:56 PDT
Created attachment 96934 [details] Proposed Patch
Martin Robinson
Comment 2 2011-06-13 09:14:56 PDT
Comment on attachment 96934 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96934&action=review > configure.ac:899 > +# check whether to enable Register Protocol Handler support. You can omit this comment. It doesn't add anything. :) > configure.ac:903 > + [enable support for Register Protocol Handler[default=no]]), Do you mind putting (experimental) here to indicate to users that this isn't finished yet? Looks like you are missing a space after Handler.
Joone Hur
Comment 3 2011-06-13 18:49:15 PDT
Created attachment 97053 [details] Updated Patch Martin, Thanks for the review!
WebKit Review Bot
Comment 4 2011-06-13 19:28:05 PDT
Comment on attachment 97053 [details] Updated Patch Clearing flags on attachment: 97053 Committed r88754: <http://trac.webkit.org/changeset/88754>
WebKit Review Bot
Comment 5 2011-06-13 19:28:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.