Bug 62534 - [GTK] Add configure option to enable/disable register protocol handler
Summary: [GTK] Add configure option to enable/disable register protocol handler
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 64247
  Show dependency treegraph
Reported: 2011-06-13 01:13 PDT by Joone Hur
Modified: 2011-07-10 19:23 PDT (History)
4 users (show)

See Also:

Proposed Patch (5.91 KB, patch)
2011-06-13 02:02 PDT, Joone Hur
mrobinson: review+
Details | Formatted Diff | Diff
Updated Patch (5.94 KB, patch)
2011-06-13 18:49 PDT, Joone Hur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joone Hur 2011-06-13 01:13:47 PDT
This patch just adds configure option to enable/disable register protocol handler.
So, it needs more code to use register protocol handler.
Comment 1 Joone Hur 2011-06-13 02:02:56 PDT
Created attachment 96934 [details]
Proposed Patch
Comment 2 Martin Robinson 2011-06-13 09:14:56 PDT
Comment on attachment 96934 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96934&action=review

> configure.ac:899
> +# check whether to enable Register Protocol Handler support.

You can omit this comment. It doesn't add anything. :)

> configure.ac:903
> +                             [enable support for Register Protocol Handler[default=no]]),

Do you mind putting (experimental) here to indicate to users that this isn't finished yet? Looks like you are missing a space after Handler.
Comment 3 Joone Hur 2011-06-13 18:49:15 PDT
Created attachment 97053 [details]
Updated Patch

Martin, Thanks for the review!
Comment 4 WebKit Review Bot 2011-06-13 19:28:05 PDT
Comment on attachment 97053 [details]
Updated Patch

Clearing flags on attachment: 97053

Committed r88754: <http://trac.webkit.org/changeset/88754>
Comment 5 WebKit Review Bot 2011-06-13 19:28:10 PDT
All reviewed patches have been landed.  Closing bug.