Bug 62519

Summary:

Remove FrameLoader::isProcessingUserGesture

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric, jnd, jochen, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ec2-cr-linux-03	none
Patch	none
Patch for landing	none

Adam Barth

Reported 2011-06-12 15:32:30 PDT

Remove FrameLoader::isProcessingUserGesture

Attachments
Patch (11.34 KB, patch) 2011-06-12 15:36 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-03 (1.50 MB, application/zip) 2011-06-12 16:07 PDT, WebKit Review Bot	no flags	Details
Patch (11.49 KB, patch) 2011-06-12 17:51 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Patch for landing (11.47 KB, patch) 2011-06-12 18:24 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2011-06-12 15:36:33 PDT

Created attachment 96894 [details] Patch

WebKit Review Bot

Comment 2 2011-06-12 16:07:16 PDT

Comment on attachment 96894 [details] Patch Attachment 96894 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8832257 New failing tests: media/video-seek-by-small-increment.html media/video-seekable.html media/video-source-error-no-candidate.html media/video-source-moved.html media/video-error-does-not-exist.html media/video-dom-preload.html media/video-loop.html media/video-pause-empty-events.html media/video-play-pause-exception.html

WebKit Review Bot

Comment 3 2011-06-12 16:07:21 PDT

Created attachment 96895 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Adam Barth

Comment 4 2011-06-12 17:51:30 PDT

Created attachment 96898 [details] Patch

Eric Seidel (no email)

Comment 5 2011-06-12 18:20:49 PDT

Comment on attachment 96898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96898&action=review > Source/WebCore/html/HTMLMediaElement.cpp:2379 > +// FIXME: We should remove this function in favor of just call ing ScriptController::processingUserGesture(). call ing

Adam Barth

Comment 6 2011-06-12 18:24:02 PDT

Created attachment 96902 [details] Patch for landing

WebKit Review Bot

Comment 7 2011-06-12 19:03:37 PDT

Comment on attachment 96902 [details] Patch for landing Clearing flags on attachment: 96902 Committed r88622: <http://trac.webkit.org/changeset/88622>

WebKit Review Bot

Comment 8 2011-06-12 19:03:45 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.