| Summary: | Remove FrameLoader::isProcessingUserGesture | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | dglazkov, eric, jnd, jochen, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Adam Barth
2011-06-12 15:32:30 PDT
Created attachment 96894 [details]
Patch
Comment on attachment 96894 [details] Patch Attachment 96894 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8832257 New failing tests: media/video-seek-by-small-increment.html media/video-seekable.html media/video-source-error-no-candidate.html media/video-source-moved.html media/video-error-does-not-exist.html media/video-dom-preload.html media/video-loop.html media/video-pause-empty-events.html media/video-play-pause-exception.html Created attachment 96895 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 96898 [details]
Patch
Comment on attachment 96898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96898&action=review > Source/WebCore/html/HTMLMediaElement.cpp:2379 > +// FIXME: We should remove this function in favor of just call ing ScriptController::processingUserGesture(). call ing Created attachment 96902 [details]
Patch for landing
Comment on attachment 96902 [details] Patch for landing Clearing flags on attachment: 96902 Committed r88622: <http://trac.webkit.org/changeset/88622> All reviewed patches have been landed. Closing bug. |