| Summary: | [Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Robert Hogan <robert> | ||||||
| Component: | New Bugs | Assignee: | Robert Hogan <robert> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, kling, ossy, rniwa, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 62926 | ||||||||
| Bug Blocks: | 62929 | ||||||||
| Attachments: |
|
||||||||
|
Description
Robert Hogan
2011-06-12 10:30:48 PDT
Created attachment 96882 [details]
Patch
Committed r89154: <http://trac.webkit.org/changeset/89154> It seems like this patch caused Qt Windows build failure: http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Debug/builds/24074/steps/compile-webkit/logs/stdio Whoops.i'll take a look in the morning. Robert, you should have watch the bots after landing instead of waiting if somebody kick in your ass. :) Please respect contributing rules and try to keep the tree green: http://www.webkit.org/coding/contributing.html "Your change must at least compile on all platforms." I had to roll it out to make the bots green again: http://trac.webkit.org/changeset/89191 Created attachment 97695 [details]
Patch
Comment on attachment 97695 [details]
Patch
ok
Comment on attachment 97695 [details] Patch Clearing flags on attachment: 97695 Committed r89213: <http://trac.webkit.org/changeset/89213> All reviewed patches have been landed. Closing bug. |