Summary: | DocumentParser::appendBytes should use size_t for length instead of int | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Adam Barth
2011-06-12 01:01:55 PDT
Created attachment 96871 [details]
Patch
Comment on attachment 96871 [details]
Patch
Looks like all these call sites ignored the argument, except for DecodedDataDocumentParser::appendBytes, which turned around and passed it to a function that takes size_t. So this patch is pure goodness.
(In reply to comment #2) > (From update of attachment 96871 [details]) > Looks like all these call sites ignored the argument, except for DecodedDataDocumentParser::appendBytes, which turned around and passed it to a function that takes size_t. So this patch is pure goodness. Yep! Comment on attachment 96871 [details] Patch Clearing flags on attachment: 96871 Committed r88623: <http://trac.webkit.org/changeset/88623> All reviewed patches have been landed. Closing bug. |