Bug 62508

Summary: DocumentParser::appendBytes should use size_t for length instead of int
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-06-12 01:01:55 PDT
DocumentParser::appendBytes should use size_t for length instead of int
Attachments
Patch (5.75 KB, patch)
2011-06-12 01:03 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-06-12 01:03:10 PDT
Created attachment 96871 [details] Patch
Darin Adler
Comment 2 2011-06-12 18:27:46 PDT
Comment on attachment 96871 [details] Patch Looks like all these call sites ignored the argument, except for DecodedDataDocumentParser::appendBytes, which turned around and passed it to a function that takes size_t. So this patch is pure goodness.
Adam Barth
Comment 3 2011-06-12 18:30:42 PDT
(In reply to comment #2) > (From update of attachment 96871 [details]) > Looks like all these call sites ignored the argument, except for DecodedDataDocumentParser::appendBytes, which turned around and passed it to a function that takes size_t. So this patch is pure goodness. Yep!
WebKit Review Bot
Comment 4 2011-06-12 19:05:40 PDT
Comment on attachment 96871 [details] Patch Clearing flags on attachment: 96871 Committed r88623: <http://trac.webkit.org/changeset/88623>
WebKit Review Bot
Comment 5 2011-06-12 19:05:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.