Bug 62502

Summary:

Allow setting content-disposition for blob-data

Product:

WebKit

Reporter:

Sadrul Habib Chowdhury <sadrul>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Normal

CC:

dglazkov, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-01	none
Fix license headers + test	none
patch	none
patch	webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-03	none
Fixed test, for real this time!	abarth: review-

Sadrul Habib Chowdhury

Reported 2011-06-11 12:24:39 PDT

It is currently possible to set the content-type for blob-data. This patch also allows setting content-disposition.

Attachments
patch (5.35 KB, patch) 2011-06-11 12:28 PDT, Sadrul Habib Chowdhury	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-01 (1.61 MB, application/zip) 2011-06-11 12:55 PDT, WebKit Review Bot	no flags	Details
Fix license headers + test (5.46 KB, patch) 2011-06-11 14:32 PDT, Sadrul Habib Chowdhury	no flags	Details Formatted Diff Diff
patch (5.38 KB, patch) 2011-06-11 15:28 PDT, Sadrul Habib Chowdhury	no flags	Details Formatted Diff Diff
patch (5.38 KB, patch) 2011-06-11 15:30 PDT, Sadrul Habib Chowdhury	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-03 (1.30 MB, application/zip) 2011-06-11 16:46 PDT, WebKit Review Bot	no flags	Details
Fixed test, for real this time! (5.58 KB, patch) 2011-06-11 17:19 PDT, Sadrul Habib Chowdhury	abarth: review-	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Sadrul Habib Chowdhury

Comment 1 2011-06-11 12:28:41 PDT

Created attachment 96858 [details] patch I have added the tests, but haven't yet been able to run; keep getting "unexpected no expected result found" errors. Will update the patch if I can get the tests to run successfully and any change is necessary. But please take a look if the approach is OK.

WebKit Review Bot

Comment 2 2011-06-11 12:55:04 PDT

Comment on attachment 96858 [details] patch Attachment 96858 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8829578 New failing tests: fast/files/blob-content-disposition.html

WebKit Review Bot

Comment 3 2011-06-11 12:55:09 PDT

Created attachment 96859 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Adam Barth

Comment 4 2011-06-11 13:22:57 PDT

Comment on attachment 96858 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=96858&action=review > Source/WebCore/fileapi/WebKitBlobBuilder.idl:2 > - * Copyright (C) 2010 Google Inc. All rights reserved. > + * Copyright (C) 2011 Google Inc. All rights reserved. nit: WebKit appends years to the copyright line rather than replacing them. No idea why.

Sadrul Habib Chowdhury

Comment 5 2011-06-11 14:31:40 PDT

Comment on attachment 96858 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=96858&action=review >> Source/WebCore/fileapi/WebKitBlobBuilder.idl:2 >> + * Copyright (C) 2011 Google Inc. All rights reserved. > > nit: WebKit appends years to the copyright line rather than replacing them. No idea why. Changed. Thanks.

Sadrul Habib Chowdhury

Comment 6 2011-06-11 14:32:38 PDT

Created attachment 96860 [details] Fix license headers + test

Sadrul Habib Chowdhury

Comment 7 2011-06-11 15:28:27 PDT

Created attachment 96862 [details] patch

Sadrul Habib Chowdhury

Comment 8 2011-06-11 15:30:01 PDT

Created attachment 96863 [details] patch

WebKit Review Bot

Comment 9 2011-06-11 16:46:37 PDT

Comment on attachment 96863 [details] patch Attachment 96863 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8833016 New failing tests: fast/files/blob-content-disposition.html

WebKit Review Bot

Comment 10 2011-06-11 16:46:41 PDT

Created attachment 96865 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Sadrul Habib Chowdhury

Comment 11 2011-06-11 17:19:29 PDT

Created attachment 96867 [details] Fixed test, for real this time! Finally figured out how to test the test! Please take a look!

Adam Barth

Comment 12 2011-06-12 00:53:45 PDT

Comment on attachment 96867 [details] Fixed test, for real this time! Is this in the spec? Marking this R- for now. Please feel to renominate if this is in the spec (I couldn't find it).

Sadrul Habib Chowdhury

Comment 13 2011-06-12 08:07:23 PDT

This indeed is not in the spec (http://www.w3.org/TR/file-writer-api/#widl-BlobBuilder-getBlob).

Note You need to log in before you can comment on or make changes to this bug.