Bug 62495 – combine windows and mac kill-old-processes script

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Lucas Forschler]

Currently a windows specific kill-old-processes script exists, and a mac-specific script exists.
We should combine the logic for these into one script, which will save complexity in the buildbot config steps.

[Lucas Forschler]

Created attachment 97023 [details]
Patch to make OS agnostic script.

[WebKit Review Bot]

Attachment 97023 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog']" exit_code: 1

Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Lucas Forschler]

Created attachment 97024 [details]
Patch to make OS agnostic script.

[Stephanie Lewis]

Comment on attachment 97023 [details]
Patch to make OS agnostic script.

View in context: https://bugs.webkit.org/attachment.cgi?id=97023&action=review

you should fix the style issue and then I will add r=me

> Tools/BuildSlaveSupport/mac/kill-old-processes:-50
> -    sys.exit(main())

Do you need to remove the window script as well?

[Lucas Forschler]

The Style issue has been fixed (see new patch).

[Lucas Forschler]

Note: I am not removing the windows script as the webkit build master still references it.  Removing it would break existing webkit bots until we could update the webkit master.

[Eric Seidel (no email)]

Comment on attachment 97024 [details]
Patch to make OS agnostic script.

View in context: https://bugs.webkit.org/attachment.cgi?id=97024&action=review

> Tools/BuildSlaveSupport/kill-old-processes:32
> +    tasksToKillWin = [ "cl.exe", 
> +					"devenv.com", 
> +					"devenv.exe", 

funny indent here.  Tabs?

[WebKit Review Bot]

Comment on attachment 97024 [details]
Patch to make OS agnostic script.

Clearing flags on attachment: 97024

Committed r88857: <http://trac.webkit.org/changeset/88857>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Comment on attachment 97023 [details]
Patch to make OS agnostic script.

Cleared review? from obsolete attachment 97023 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).