Bug 62445

Summary: [EFL][WK2] Add dummy files at below of WebProcess.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, leandro, lucas.de.marchi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch
none
Patch none

Description Ryuan Choi 2011-06-10 03:13:53 PDT 
patch will be added.
Comment 1 Ryuan Choi 2011-06-10 03:39:17 PDT 
Created attachment 96725 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2011-06-10 04:19:48 PDT 
Comment on attachment 96725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96725&action=review

> Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp:33
> +    // FIXME: Not implemented.

why not use notImplemented() ? please do that

> Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:42
> +    ASSERT(argc == 2);

Why not handle it instead
Comment 3 Ryuan Choi 2011-06-13 02:30:02 PDT 
Created attachment 96939 [details]
Patch
Comment 4 Ryuan Choi 2011-06-13 02:30:50 PDT 
(In reply to comment #2)
> (From update of attachment 96725 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96725&action=review
> 
> > Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp:33
> > +    // FIXME: Not implemented.
> 
> why not use notImplemented() ? please do that
> 
> > Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:42
> > +    ASSERT(argc == 2);
> 
> Why not handle it instead

Thanks, I fixed what you mentioned.
Comment 5 Leandro Pereira 2011-06-13 12:31:43 PDT 
(In reply to comment #4)
> 
> Thanks, I fixed what you mentioned.
>

LGTM.
Comment 6 WebKit Review Bot 2011-06-13 15:45:11 PDT 
Comment on attachment 96939 [details]
Patch

Clearing flags on attachment: 96939

Committed r88722: <http://trac.webkit.org/changeset/88722>
Comment 7 WebKit Review Bot 2011-06-13 15:45:17 PDT 
All reviewed patches have been landed.  Closing bug.