Bug 62445

Summary: [EFL][WK2] Add dummy files at below of WebProcess.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, leandro, lucas.de.marchi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch
none
Patch none

Ryuan Choi
Reported 2011-06-10 03:13:53 PDT
patch will be added.
Attachments
Patch (20.41 KB, patch)
2011-06-10 03:39 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (20.41 KB, patch)
2011-06-13 02:30 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-06-10 03:39:17 PDT
Created attachment 96725 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2011-06-10 04:19:48 PDT
Comment on attachment 96725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96725&action=review > Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp:33 > + // FIXME: Not implemented. why not use notImplemented() ? please do that > Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:42 > + ASSERT(argc == 2); Why not handle it instead
Ryuan Choi
Comment 3 2011-06-13 02:30:02 PDT
Created attachment 96939 [details] Patch
Ryuan Choi
Comment 4 2011-06-13 02:30:50 PDT
(In reply to comment #2) > (From update of attachment 96725 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96725&action=review > > > Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp:33 > > + // FIXME: Not implemented. > > why not use notImplemented() ? please do that > > > Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:42 > > + ASSERT(argc == 2); > > Why not handle it instead Thanks, I fixed what you mentioned.
Leandro Pereira
Comment 5 2011-06-13 12:31:43 PDT
(In reply to comment #4) > > Thanks, I fixed what you mentioned. > LGTM.
WebKit Review Bot
Comment 6 2011-06-13 15:45:11 PDT
Comment on attachment 96939 [details] Patch Clearing flags on attachment: 96939 Committed r88722: <http://trac.webkit.org/changeset/88722>
WebKit Review Bot
Comment 7 2011-06-13 15:45:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.