Bug 62442

Summary: [Qt] LayoutTestController needs setTextDirection implementation
Product: WebKit Reporter: Mahesh Kulkarni <maheshk>
Component: Tools / TestsAssignee: Mahesh Kulkarni <maheshk>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, laszlo.gombos, rniwa, tonikitoo
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Bug Depends on: 62517    
Bug Blocks:    
Attachments:
Description Flags
patch none

Mahesh Kulkarni
Reported 2011-06-10 02:14:55 PDT
fast/html/set-text-direction.html is failing in Qt port because LayoutTestController needs setTextDirection implementation.
Attachments
patch (3.40 KB, patch)
2011-06-10 02:21 PDT, Mahesh Kulkarni 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mahesh Kulkarni
Comment 1 2011-06-10 02:21:43 PDT
Created attachment 96717 [details] patch Implements setTextDirection using QWebPage actions.
Ryosuke Niwa
Comment 2 2011-06-12 13:27:17 PDT
It seems like findString.html is failing on Qt bot after this patch is landed: http://build.webkit.org/results/Qt%20Linux%20Release/r88616%20(34105)/results.html http://build.webkit.org/results/Qt%20Linux%20Release/r88619%20(34108)/results.html
Antonio Gomes
Comment 3 2011-06-12 14:21:21 PDT
Do you need to reset the direction value before each test execution?
Antonio Gomes
Comment 4 2011-06-12 14:58:36 PDT
rolled out by to fix the test offline.
Mahesh Kulkarni
Comment 5 2011-06-12 20:20:03 PDT
(In reply to comment #3) > Do you need to reset the direction value before each test execution? Sorry for the confusion created, This bug fixes only > # LayoutTestController::setTextDirection is not implemented. > fast/html/set-text-direction.html I was working next on findString() and committed with below case commented. > # Missing layoutTestController.findString() http://webkit.org/b/50236 > # editing/text-iterator/findString.html I will use webkit-patch land-attachment from now on and land the patch reviewed :)
Mahesh Kulkarni
Comment 6 2011-06-12 21:13:24 PDT
Comment on attachment 96717 [details] patch Clearing flags on attachment: 96717 Committed r88626: <http://trac.webkit.org/changeset/88626>
Mahesh Kulkarni
Comment 7 2011-06-12 21:13:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.