| Summary: | [Qt] LayoutTestController needs setTextDirection implementation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mahesh Kulkarni <maheshk> | ||||
| Component: | Tools / Tests | Assignee: | Mahesh Kulkarni <maheshk> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | kling, laszlo.gombos, rniwa, tonikitoo | ||||
| Priority: | P2 | Keywords: | Qt | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Bug Depends on: | 62517 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Mahesh Kulkarni
2011-06-10 02:14:55 PDT
Created attachment 96717 [details]
patch
Implements setTextDirection using QWebPage actions.
It seems like findString.html is failing on Qt bot after this patch is landed: http://build.webkit.org/results/Qt%20Linux%20Release/r88616%20(34105)/results.html http://build.webkit.org/results/Qt%20Linux%20Release/r88619%20(34108)/results.html Do you need to reset the direction value before each test execution? rolled out by to fix the test offline. (In reply to comment #3) > Do you need to reset the direction value before each test execution? Sorry for the confusion created, This bug fixes only > # LayoutTestController::setTextDirection is not implemented. > fast/html/set-text-direction.html I was working next on findString() and committed with below case commented. > # Missing layoutTestController.findString() http://webkit.org/b/50236 > # editing/text-iterator/findString.html I will use webkit-patch land-attachment from now on and land the patch reviewed :) Comment on attachment 96717 [details] patch Clearing flags on attachment: 96717 Committed r88626: <http://trac.webkit.org/changeset/88626> All reviewed patches have been landed. Closing bug. |