Bug 62428

Summary:

ShadowContentElement should detach its inclusions before attach them.

Product:

WebKit

Reporter:

Hajime Morrita <morrita>

Component:

DOM

Assignee:

Hajime Morrita <morrita>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

62202

Attachments:

Description	Flags
Patch	none
Updated to ToT	none
Patch	dglazkov: review+

Description Hajime Morrita 2011-06-09 22:09:13 PDT

This is a preparation for Bug 59802.

Comment 1 Hajime Morrita 2011-06-09 23:05:50 PDT

Created attachment 96697 [details]
Patch

Comment 2 Hajime Morrita 2011-06-12 22:57:13 PDT

Created attachment 96921 [details]
Updated to ToT

Comment 3 Dimitri Glazkov (Google) 2011-06-13 15:13:41 PDT

Comment on attachment 96921 [details]
Updated to ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=96921&action=review

> Source/WebCore/ChangeLog:5
> +        ShadowContentElement should detach its inclusions before attach them.

"before attaching them".

> Source/WebCore/dom/ShadowContentElement.cpp:40
> +        selector->selectIncludesion(m_inclusions);

includesion is not a real word. Did you mean inclusion?

Comment 4 Hajime Morrita 2011-06-13 22:45:44 PDT

Created attachment 97069 [details]
Patch

Comment 5 Hajime Morrita 2011-06-14 23:24:35 PDT

Committed r88908: <http://trac.webkit.org/changeset/88908>