Bug 62423

Summary:

[Chromium] Add WebSettings::setShouldPrintBackgrounds()

Product:

WebKit

Reporter:

Lei Zhang <thestig>

Component:

Platform

Assignee:

Lei Zhang <thestig>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fishd, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch to add setShouldPrintBackgrounds()	fishd: review-
Added comment to ChangeLog	fishd: review-
Add bug url to changelog	none

Lei Zhang

Reported 2011-06-09 19:33:35 PDT

Created attachment 96688 [details] Patch to add setShouldPrintBackgrounds() Hook up setShouldPrintBackgrounds for http://crbug.com/2294

Attachments
Patch to add setShouldPrintBackgrounds() (2.11 KB, patch) 2011-06-09 19:33 PDT, Lei Zhang	fishd: review-	Details Formatted Diff Diff
Added comment to ChangeLog (2.12 KB, patch) 2011-06-13 13:39 PDT, Lei Zhang	fishd: review-	Details Formatted Diff Diff
Add bug url to changelog (2.18 KB, patch) 2011-06-13 15:33 PDT, Lei Zhang	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Lei Zhang

Comment 1 2011-06-10 12:50:05 PDT

+fishd

Darin Fisher (:fishd, Google)

Comment 2 2011-06-10 22:34:44 PDT

Comment on attachment 96688 [details] Patch to add setShouldPrintBackgrounds() View in context: https://bugs.webkit.org/attachment.cgi?id=96688&action=review Patch looks good except for the ChangeLog entry. > WebKit/chromium/ChangeLog:5 > + Need a short description and bug URL (OOPS!) you need to do as this says :)

Lei Zhang

Comment 3 2011-06-13 13:39:41 PDT

Created attachment 97000 [details] Added comment to ChangeLog Whoops indeed.

Darin Fisher (:fishd, Google)

Comment 4 2011-06-13 15:20:58 PDT

Comment on attachment 97000 [details] Added comment to ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=97000&action=review You forgot to set the '?' on the patch, which meant that it didn't go into the review request queue :-( > WebKit/chromium/ChangeLog:5 > + [Chromium] Add a WebSetting to control printing backgrounds sorry to give you a hard time, but you are also supposed to include the URL of this bug report here. please take a look at how other people write ChangeLog entries.

Lei Zhang

Comment 5 2011-06-13 15:33:27 PDT

Created attachment 97020 [details] Add bug url to changelog That's ok. Third time is the charm.

WebKit Review Bot

Comment 6 2011-06-13 15:57:08 PDT

Comment on attachment 97020 [details] Add bug url to changelog Clearing flags on attachment: 97020 Committed r88728: <http://trac.webkit.org/changeset/88728>

WebKit Review Bot

Comment 7 2011-06-13 15:57:13 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.