Bug 62400

Summary:

Roll out r88468, and fix bug #61911 without making Element::offset functions virtual.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

WebCore Misc.

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hyatt, mjs

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	hyatt: review+

Jer Noble

Reported 2011-06-09 13:43:40 PDT

Hyatt doesn't like the fix in bug #61911, <http://trac.webkit.org/changeset/88468>, and suggested a different way of achieving the same effect.

Attachments
Patch (6.60 KB, patch) 2011-06-09 13:47 PDT, Jer Noble	hyatt: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2011-06-09 13:47:19 PDT

Created attachment 96634 [details] Patch

Dave Hyatt

Comment 2 2011-06-09 13:49:22 PDT

Comment on attachment 96634 [details] Patch r=me! Thanks for the quick turnaround!

Jer Noble

Comment 3 2011-06-09 14:02:52 PDT

http://jerryseinfeld.com/ content still appears fixed with this patch. No major regressions found on apple.com content, vimeo.com content, or embedded vimeo.com videos.

Jer Noble

Comment 4 2011-06-09 14:04:01 PDT

<rdar://problem/9582672>

Jer Noble

Comment 5 2011-06-09 17:03:29 PDT

Committed r88505: <http://trac.webkit.org/changeset/88505>

Note You need to log in before you can comment on or make changes to this bug.