Bug 62400 - Roll out r88468, and fix bug #61911 without making Element::offset functions virtual.
: Roll out r88468, and fix bug #61911 without making Element::offset functions ...
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebCore Misc.
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Jer Noble
: InRadar
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-09 13:43 PDT by Jer Noble
Modified: 2011-06-09 17:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.60 KB, patch)
2011-06-09 13:47 PDT, Jer Noble
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-06-09 13:43:40 PDT
Hyatt doesn't like the fix in bug #61911, <http://trac.webkit.org/changeset/88468>, and suggested a different way of achieving the same effect.
Comment 1 Jer Noble 2011-06-09 13:47:19 PDT
Created attachment 96634 [details]
Patch
Comment 2 Dave Hyatt 2011-06-09 13:49:22 PDT
Comment on attachment 96634 [details]
Patch

r=me! Thanks for the quick turnaround!
Comment 3 Jer Noble 2011-06-09 14:02:52 PDT
http://jerryseinfeld.com/ content still appears fixed with this patch.  No major regressions found on apple.com content, vimeo.com content, or embedded vimeo.com videos.
Comment 4 Jer Noble 2011-06-09 14:04:01 PDT
<rdar://problem/9582672>
Comment 5 Jer Noble 2011-06-09 17:03:29 PDT
Committed r88505: <http://trac.webkit.org/changeset/88505>