Bug 62397

Summary: [chromium] webkitRequestFullscreen exposed to web even when feature is disabled
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: ddorwin, dglazkov, eric.carlson, eric, fishd, jer.noble, mjs, scherkus, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
re-upload to let EWS chew on it again none

James Robinson
Reported 2011-06-09 13:23:29 PDT
[chromium] webkitRequestFullscreen exposed to web even when feature is disabled
Attachments
Patch (1.33 KB, patch)
2011-06-09 13:26 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (3.56 KB, patch)
2011-06-09 13:46 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
re-upload to let EWS chew on it again (3.56 KB, patch)
2011-06-09 15:41 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-06-09 13:26:10 PDT
Created attachment 96628 [details] Patch
James Robinson
Comment 2 2011-06-09 13:46:45 PDT
Created attachment 96632 [details] Patch
Eric Seidel (no email)
Comment 3 2011-06-09 13:56:09 PDT
Comment on attachment 96632 [details] Patch LGTM.
WebKit Review Bot
Comment 4 2011-06-09 14:32:18 PDT
Comment on attachment 96632 [details] Patch Rejecting attachment 96632 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: rror: 'toRenderFullScreen' was not declared in this scope Source/WebCore/html/HTMLMediaElement.cpp:2726: error: invalid use of incomplete type 'struct WebCore::RenderFullScreen' Source/WebCore/dom/Document.h:114: error: forward declaration of 'struct WebCore::RenderFullScreen' CXX(target) out/Debug/obj.target/webcore_html/Source/WebCore/html/HTMLMeterElement.o make: *** [out/Debug/obj.target/webcore_html/Source/WebCore/html/HTMLMediaElement.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/8812817
James Robinson
Comment 5 2011-06-09 14:36:25 PDT
Looks like the ENABLE_FULLSCREEN_API=0 path has compile-rotted on mac (and apparently on win too from my trybot results). I'll update the patch...
WebKit Review Bot
Comment 6 2011-06-09 14:37:26 PDT
Comment on attachment 96632 [details] Patch Attachment 96632 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8826167
James Robinson
Comment 7 2011-06-09 15:41:22 PDT
Created attachment 96655 [details] re-upload to let EWS chew on it again
James Robinson
Comment 8 2011-06-09 15:42:00 PDT
This should compile now that http://trac.webkit.org/changeset/88490 has landed.
James Robinson
Comment 9 2011-06-09 17:30:40 PDT
Committed r88507: <http://trac.webkit.org/changeset/88507>
Note You need to log in before you can comment on or make changes to this bug.