Summary: | [chromium] webkitRequestFullscreen exposed to web even when feature is disabled | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||||
Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ddorwin, dglazkov, eric.carlson, eric, fishd, jer.noble, mjs, scherkus, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
James Robinson
2011-06-09 13:23:29 PDT
Created attachment 96628 [details]
Patch
Created attachment 96632 [details]
Patch
Comment on attachment 96632 [details]
Patch
LGTM.
Comment on attachment 96632 [details] Patch Rejecting attachment 96632 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: rror: 'toRenderFullScreen' was not declared in this scope Source/WebCore/html/HTMLMediaElement.cpp:2726: error: invalid use of incomplete type 'struct WebCore::RenderFullScreen' Source/WebCore/dom/Document.h:114: error: forward declaration of 'struct WebCore::RenderFullScreen' CXX(target) out/Debug/obj.target/webcore_html/Source/WebCore/html/HTMLMeterElement.o make: *** [out/Debug/obj.target/webcore_html/Source/WebCore/html/HTMLMediaElement.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/8812817 Looks like the ENABLE_FULLSCREEN_API=0 path has compile-rotted on mac (and apparently on win too from my trybot results). I'll update the patch... Comment on attachment 96632 [details] Patch Attachment 96632 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8826167 Created attachment 96655 [details]
re-upload to let EWS chew on it again
This should compile now that http://trac.webkit.org/changeset/88490 has landed. Committed r88507: <http://trac.webkit.org/changeset/88507> |