Bug 62395 – IndexedDB: objectStore.transaction property should be readonly

• Component: New Bugs
• Status: RESOLVED FIXED

[Mark Pilgrim (Google)]

Created attachment 96621 [details]
test case

http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBObjectStore-transaction states that the transaction property of an object store is readonly, but setting it changes the value.

Test case attached.

[Joshua Bell]

Created attachment 111994 [details]
Patch

[Adam Barth]

Comment on attachment 111994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111994&action=review

> Source/WebCore/storage/IDBObjectStore.cpp:71
> +PassRefPtr<IDBTransaction> IDBObjectStore::transaction() const

This should just be a raw pointer.

> Source/WebCore/storage/IDBObjectStore.idl:34
> +        readonly attribute IDBTransaction transaction;

I assume this is in the spec.

[Joshua Bell]

Created attachment 112007 [details]
Patch

[Joshua Bell]

Thanks, and yes - it is defined in the spec - added a mention of that in the ChangeLog note. Also tracked as crbug.com/92042

[Adam Barth]

Comment on attachment 112007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112007&action=review

> Source/WebCore/ChangeLog:8
> +        Implement the IDBObjectStore.transaction property defined by the spec.

Yeah, I saw this line but I couldn't verify it because there wasn't a link.  A link isn't necessary, that's why I mentioned that I'm trusted you that it's in the spec.  :)

[WebKit Review Bot]

Comment on attachment 112007 [details]
Patch

Clearing flags on attachment: 112007

Committed r98154: <http://trac.webkit.org/changeset/98154>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.