Bug 62394

Summary: [CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms without plugin support
Product: WebKit Reporter: Leandro Pereira <leandro>
Component: New BugsAssignee: Leandro Pereira <leandro>
Status: RESOLVED FIXED    
Severity: Normal CC: paroga, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Leandro Pereira 2011-06-09 13:05:05 PDT 
[CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms without plugin support
Comment 1 Leandro Pereira 2011-06-09 13:22:48 PDT 
Created attachment 96625 [details]
Patch
Comment 2 Patrick R. Gansterer 2011-06-09 13:36:49 PDT 
Comment on attachment 96625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96625&action=review

> Source/WebCore/CMakeLists.txt:-1507
> -    LIST(APPEND WebCore_SOURCES
> -        plugins/PluginPackageNone.cpp
> -        plugins/PluginViewNone.cpp
> -    )

IMO you also need to add PluginPackageNone and PluginViewNone in the ELSE() at CMakeListsWinCE.txt.
Comment 3 Leandro Pereira 2011-06-09 13:44:28 PDT 
Created attachment 96631 [details]
Patch
Comment 4 Eric Seidel (no email) 2011-06-13 15:06:45 PDT 
Comment on attachment 96631 [details]
Patch

OK.  rs=me.
Comment 5 WebKit Review Bot 2011-06-13 15:23:34 PDT 
Comment on attachment 96631 [details]
Patch

Clearing flags on attachment: 96631

Committed r88711: <http://trac.webkit.org/changeset/88711>
Comment 6 WebKit Review Bot 2011-06-13 15:23:38 PDT 
All reviewed patches have been landed.  Closing bug.