[chromium-win] Register protocol handler tests are failing on build.webkit.org

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Ryosuke Niwa]

It seems like the flags aren't enabled properly on build.webkit.org bots:
http://build.webkit.org/results/Chromium%20Win%20Release%20(Tests)/r88434%20(15286)/results.html

[James Robinson]

This is a bit strange - it seems that the ENABLE_REGISTER_... macro is not on for these bots, although when I regenerate the visual studio projects locally it's definitely set to true.  The bots need a kick perhaps?

[Tony Chang]

I'll check on the bot.

[Tony Chang]

Oh, in the checked in code, I think it's disabled for all upstream builds since it's set to 0 in the top of features.gypi.  In chromium checkouts, features_override.gypi enables it.

The reason the variable in build/common.gypi doesn't override is because in features.gypi, the nesting puts the condition in a scope that doesn't see the value in build/common.gypi.

This will be fixed by bug 62399.

[Tony Chang]

Seems green after landing the patch on bug 62399 and clobbering the build to pick up the compiler flag changes.

[Ryosuke Niwa]

fast/dom/navigator-detached-no-crash.html is failing on Mac:

http://build.webkit.org/results/Chromium%20Mac%20Release%20(Tests)/r88574%20(8082)/fast/dom/navigator-detached-no-crash-pretty-diff.html

[Dimitri Glazkov (Google)]

(In reply to comment #5)
> fast/dom/navigator-detached-no-crash.html is failing on Mac:
> 
> http://build.webkit.org/results/Chromium%20Mac%20Release%20(Tests)/r88574%20(8082)/fast/dom/navigator-detached-no-crash-pretty-diff.html

I re-clobbered teh bot. Let's see what happens.

[Ryosuke Niwa]

It seems like the test has been passing, closing the bug.