Bug 62327

Summary: Add faster lookup cache for multi character identifiers
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Oliver Hunt
Reported 2011-06-08 14:17:56 PDT
Add faster lookup cache for multi character identifiers
Attachments
Patch (3.64 KB, patch)
2011-06-08 14:22 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-06-08 14:22:38 PDT
Created attachment 96481 [details] Patch
Oliver Hunt
Comment 2 2011-06-08 14:23:25 PDT
This is a 1.7% parsing improvement by my measurements.
Geoffrey Garen
Comment 3 2011-06-08 14:31:30 PDT
Comment on attachment 96481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96481&action=review r=me > Source/JavaScriptCore/parser/ParserArena.h:82 > + if (ident && ident->length() == (int)length && (!memcmp(characters, ident->characters(), length * sizeof(UChar)))) static_cast<int>, please.
Geoffrey Garen
Comment 4 2011-06-08 14:35:22 PDT
Just realized that Identifier::equal might be a better choice than memcmp.
Oliver Hunt
Comment 5 2011-06-08 14:57:34 PDT
Committed r88394: <http://trac.webkit.org/changeset/88394>
Note You need to log in before you can comment on or make changes to this bug.