| Summary: | Fix clang issue, virtual function const mismatch | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Simonsen <simonjam> | ||||
| Component: | New Bugs | Assignee: | James Simonsen <simonjam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dglazkov, jamesr, tonyg | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
James Simonsen
2011-06-08 12:40:50 PDT
Created attachment 96463 [details]
Patch
Committed r88382: <http://trac.webkit.org/changeset/88382> Comment on attachment 96463 [details]
Patch
This almost certainly had some real symptom too. When possible we try to make a test case to show what was broken.
(In reply to comment #3) > (From update of attachment 96463 [details]) > This almost certainly had some real symptom too. When possible we try to make a test case to show what was broken. Fortunately, the code was only broken in the tree for several hours. Chromium runs clang on all WebKit rolls and those happen a few times a day. I expect that we'll catch these sorts of bugs pretty quickly. I hope someone is working on a Clang EWS bot. That would be even quicker at detecting these sorts of problems. > I hope someone is working on a Clang EWS bot. That would be even quicker at detecting these sorts of problems.
Great idea. I'll talk to Nico about that.
The instructions are here. We'll need to adapt them a bit to work for WebKit: http://code.google.com/p/chromium/wiki/Clang This isn't high on my priority list, but it definitely sounds like something we should do. |