Summary: | IndexedDB test: key sort order for Date objects | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dgrogan, hans, tony, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Pilgrim (Google)
2011-06-08 11:24:50 PDT
Created attachment 96443 [details]
Patch
Comment on attachment 96443 [details]
Patch
LGTM
Comment on attachment 96443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96443&action=review LGTM > LayoutTests/storage/indexeddb/key-sort-order-date.html:89 > + shouldBe("cursor.key.toString()", "sortedKeys[keyIndex]"); So the problem with dates is that shouldBe will try to compare Date objects using == ? If so you might be able to use shouldEvaluateTo: shouldEvaluateTo("cursor.key", sortedKeys[keyIndex]) if sortedKeys[keyIndex] holds a date.toString(), the == might call the Date object's toString method before comparing. It's no big deal, the test is fine as is. Only do this if you want to play around with javascript. Comment on attachment 96443 [details]
Patch
Mark, if you want to land this patch as-is, please set cq?. Otherwise, just upload a new patch.
Comment on attachment 96443 [details] Patch Clearing flags on attachment: 96443 Committed r88395: <http://trac.webkit.org/changeset/88395> All reviewed patches have been landed. Closing bug. |