Summary: | Web Inspector: script links are displayed with original line number in pretty-print mode. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Podivilov <podivilov> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Podivilov <podivilov> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Pavel Podivilov
2011-06-08 07:59:06 PDT
Created attachment 96422 [details]
Patch.
Comment on attachment 96422 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=96422&action=review > Source/WebCore/inspector/front-end/Panel.js:394 > + linkText += ":" + (lineNumber + 1); Common panel code shouldn't contain lineNumber arithmetic. > Source/WebCore/inspector/front-end/inspector.js:1280 > + var node = this.panels[preferredPanel].createAnchor(url, lineNumber - 1, classes, tooltipText); This method shouldn't modify lineNumber. Comment on attachment 96422 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=96422&action=review > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:106 > + { Anchors may be removed so there should be corresponding method that would remove them from _anchors here. (In reply to comment #2) > (From update of attachment 96422 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96422&action=review > > > Source/WebCore/inspector/front-end/Panel.js:394 > > + linkText += ":" + (lineNumber + 1); > > Common panel code shouldn't contain lineNumber arithmetic. > > > Source/WebCore/inspector/front-end/inspector.js:1280 > > + var node = this.panels[preferredPanel].createAnchor(url, lineNumber - 1, classes, tooltipText); > > This method shouldn't modify lineNumber. Added fixme to make console call frame line/column numbers zero-based just like in debugger call frames. > Anchors may be removed so there should be corresponding method that would remove them from _anchors here. Anchors are cleared on navigation, so we may keep removed anchors in the list. Created attachment 96564 [details]
Patch.
Comment on attachment 96564 [details]
Patch.
How do we test this?
Created attachment 97268 [details]
Added test.
Comment on attachment 97268 [details] Added test. View in context: https://bugs.webkit.org/attachment.cgi?id=97268&action=review > Source/WebCore/inspector/front-end/inspector.js:1281 > + // FIXME: stack trace line/column numbers are one-based. Please file a bug on this. Committed r88927: <http://trac.webkit.org/changeset/88927> (In reply to comment #8) > (From update of attachment 97268 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97268&action=review > > > Source/WebCore/inspector/front-end/inspector.js:1281 > > + // FIXME: stack trace line/column numbers are one-based. > > Please file a bug on this. https://bugs.webkit.org/show_bug.cgi?id=62725. |