Bug 62263

Summary:

[Chromium] Add stubs to WebWidget

Product:

WebKit

Reporter:

Sailesh Agrawal <sail>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fishd, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Sailesh Agrawal 2011-06-07 22:02:29 PDT

Remove stubs for WebWidget::willStartLiveResize and WebWidget::willEndLiveResize

Comment 1 Sailesh Agrawal 2011-06-07 22:03:25 PDT

Created attachment 96379 [details]
Patch

Comment 2 Sailesh Agrawal 2011-06-07 22:04:02 PDT

Waiting for Chromium try bots to complete before asking for review.

Comment 3 Sailesh Agrawal 2011-06-08 10:20:42 PDT

Try bots passed.

Comment 4 Darin Fisher (:fishd, Google) 2011-06-08 16:39:27 PDT

Comment on attachment 96379 [details]
Patch

I think a better fix would be to make all of the methods have default implementations
since there is an implementation of WebWidget in the Chromium repository.  If you don't
do that then we will continually have to repeat this exercise.  It would be better if
the code guided people to add default implementations (which is what we do for other
interfaces that Chromium implements -- e.g., WebFrameClient).

Comment 5 Sailesh Agrawal 2011-06-08 20:55:18 PDT

Created attachment 96539 [details]
Patch

Comment 6 Sailesh Agrawal 2011-06-08 20:56:43 PDT

Default implementations added for all methods in WebWidget.

Comment 7 Darin Fisher (:fishd, Google) 2011-06-08 21:56:38 PDT

Comment on attachment 96539 [details]
Patch

Thanks!  R+CQ=me

Comment 8 WebKit Review Bot 2011-06-08 22:35:32 PDT

Comment on attachment 96539 [details]
Patch

Clearing flags on attachment: 96539

Committed r88422: <http://trac.webkit.org/changeset/88422>

Comment 9 WebKit Review Bot 2011-06-08 22:35:36 PDT

All reviewed patches have been landed.  Closing bug.