Bug 62258

Summary:

(CG) Sub-image drawing clips unnecessarily

Product:

WebKit

Reporter:

Ian Henderson <ian>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

koz, mitz, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.6

Attachments:

Description	Flags
proposed patch	none

Ian Henderson

Reported 2011-06-07 19:30:36 PDT

When drawing sub-images in BitmapImage::draw, we clip to destRect, then draw into adjustedDestRect. If they're the same, we could avoid clipping and just draw the image.

Attachments
proposed patch (1.41 KB, patch) 2011-06-07 20:06 PDT, Ian Henderson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ian Henderson

Comment 1 2011-06-07 19:31:54 PDT

rdar://problem/9567167

Ian Henderson

Comment 2 2011-06-07 20:06:52 PDT

Created attachment 96366 [details] proposed patch

WebKit Review Bot

Comment 3 2011-06-07 20:31:38 PDT

Comment on attachment 96366 [details] proposed patch Clearing flags on attachment: 96366 Committed r88321: <http://trac.webkit.org/changeset/88321>

WebKit Review Bot

Comment 4 2011-06-07 20:31:42 PDT

All reviewed patches have been landed. Closing bug.

James Kozianski

Comment 5 2011-06-07 22:33:06 PDT

I think this caused some pixel changes for SnowLeopard. The changes seemed fine to me so I commit them in r88325 if you wanted to verify.

Note You need to log in before you can comment on or make changes to this bug.