Bug 62239

Summary:

V8NodeFilterCondition should use OwnHandle

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

antonm, dglazkov, eric, levin, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

62193

Attachments:

Description	Flags
Patch	none
Patch for landing	webkit.review.bot: commit-queue-

Adam Barth

Reported 2011-06-07 15:26:35 PDT

V8NodeFilterCondition should use OwnHandle

Attachments
Patch (3.25 KB, patch) 2011-06-07 15:27 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Patch for landing (4.31 KB, patch) 2011-06-22 12:35 PDT, Adam Barth	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2011-06-07 15:27:07 PDT

Created attachment 96313 [details] Patch

Eric Seidel (no email)

Comment 2 2011-06-07 16:31:26 PDT

Comment on attachment 96313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96313&action=review > Source/WebCore/bindings/v8/V8NodeFilterCondition.cpp:63 > + if (!m_filter.get()->IsObject()) Why don't we override -> on OwnHandle like we do for our other smartpointers?

Adam Barth

Comment 3 2011-06-07 18:07:45 PDT

(In reply to comment #2) > (From update of attachment 96313 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96313&action=review > > > Source/WebCore/bindings/v8/V8NodeFilterCondition.cpp:63 > > + if (!m_filter.get()->IsObject()) > > Why don't we override -> on OwnHandle like we do for our other smartpointers? We could. It's a little confusing because v8::Handle has a bunch of APIs that you access with "." that are useful too.

Adam Barth

Comment 4 2011-06-13 09:57:27 PDT

Adding some potential reviewers.

Adam Barth

Comment 5 2011-06-13 09:59:50 PDT

Thank you sir.

WebKit Review Bot

Comment 6 2011-06-13 10:33:29 PDT

Comment on attachment 96313 [details] Patch Rejecting attachment 96313 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: Source/WebCore/bindings/v8/V8GCController.h:72: note: candidates are: static void WebCore::V8GCController::unregisterGlobalHandle(void*, v8::Persistent<v8::Value>) CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/V8Proxy.o CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/V8Utilities.o make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/V8NodeFilterCondition.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/8833496

Adam Barth

Comment 7 2011-06-22 12:35:07 PDT

Created attachment 98216 [details] Patch for landing

WebKit Review Bot

Comment 8 2011-06-22 16:35:34 PDT

Comment on attachment 98216 [details] Patch for landing Rejecting attachment 98216 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: lHandle(WebCore::V8NodeFilterCondition* const, v8::Handle<v8::Value>)' Source/WebCore/bindings/v8/V8GCController.h:72: note: candidates are: static void WebCore::V8GCController::unregisterGlobalHandle(void*, v8::Persistent<v8::Value>) CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/custom/V8WebKitAnimationCustom.o make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/V8NodeFilterCondition.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/8921858

Note You need to log in before you can comment on or make changes to this bug.