| Summary: | [Qt] RenderThemeQt::adjustSliderThumbSize() should not refer to the parent style | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
| Component: | Layout and Rendering | Assignee: | Kent Tamura <tkent> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dglazkov, hausmann, kling, vestbo | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 52920, 62208 | ||||||
| Attachments: |
|
||||||
|
Description
Kent Tamura
2011-06-07 06:32:15 PDT
Created attachment 96241 [details]
Patch
Comment on attachment 96241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96241&action=review Thanks for lookin' out for Qt! <3 r=me > Source/WebCore/ChangeLog:13 > + * platform/qt/RenderThemeQt.cpp: Use fixed values to avoid to refer to o->parent(). to refer -> referring > Source/WebCore/platform/qt/RenderThemeQt.cpp:1468 > + // timelineThumbHeight should match to the height property of -webkit-media-controls-timeline in mediaControlsQt.css. match to -> match > Source/WebCore/platform/qt/RenderThemeQt.cpp:1471 > + // volumeThmbWidth should match to the width property of -webkit-media-controls-volue-slider in mediaControlsQt.css. match to -> match volumeThmbWidth -> volumeThumbWidth volue -> volume (In reply to comment #2) Thank you for reviewing! I'll land with these English corrections. Committed r88294: <http://trac.webkit.org/changeset/88294> |