Bug 62124

Summary:

Do not use NPRuntimeObjectMap in NetscapePlugin::setException when plug-in is running out of process

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Bug Depends on:

Bug Blocks:

60546

Attachments:

Description	Flags
Patch	andersca: review+

Description Carlos Garcia Campos 2011-06-06 06:38:05 PDT

In the GTK+ port we build the plugin process with only the minimum files required, because we need to compile it with gtk2 even when building webkit with gtk3. NPRuntimeObjectMap::setGlobalException(exceptionString); breaks the build for us when building with plugin process enabled.

Comment 1 Carlos Garcia Campos 2011-06-06 06:41:48 PDT

Created attachment 96083 [details]
Patch

Use #if !ENABLE(PLUGIN_PROCESS) block as suggested by Anders, it doesn't really fix the FIXME, but it allows us to build for now.

Comment 2 Anders Carlsson 2011-06-06 07:19:05 PDT

Comment on attachment 96083 [details]
Patch

Could you change the #ifdef to read something like:

#if ENABLE(PLUGIN_PROCESS)
// FIXME ...
#else
NPRuntimeObjectmap::setGlobalException()
#end

Comment 3 Carlos Garcia Campos 2011-06-06 10:07:13 PDT

Sure!

Comment 4 Carlos Garcia Campos 2011-06-06 10:10:33 PDT

Committed r88171: <http://trac.webkit.org/changeset/88171>