| Summary: | [Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||
| Component: | Page Loading | Assignee: | Darin Adler <darin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Darin Adler
2011-06-04 12:26:35 PDT
Created attachment 96030 [details]
Patch
Comment on attachment 96030 [details]
Patch
I don't think CoreIPCThread is a good name, it might be mistaken for the CoreIPC work queue that sends/receives message.
a CoreIPC connection has the notion of a "client run loop" where incoming messages will be dispatched. Maybe callOnCoreIPCClientRunLoopAndWait is a better name.
(In reply to comment #2) > Maybe callOnCoreIPCClientRunLoopAndWait is a better name. Sure thing; I’ll change to that name. Any ideas for better names for the source files CoreIPCThread.h/mm? Created attachment 96031 [details]
Patch
Committed r88123: <http://trac.webkit.org/changeset/88123> Comment on attachment 96031 [details]
Patch
The patch I landed also included a FIXME comment explaining we could do this with work items instead.
|